Hi On Mon, Sep 15, 2014 at 5:13 AM, Michael Wright <[email protected]> wrote: > Improve gamepad support by introducing new LED constants for player > LEDs and the mappings from their corresponding HID usages introduced > in HUTTR47: http://www.usb.org/developers/hidpage/HUTRR47.pdf
Why not introduce all 8 player LEDs as described in the document? You should be safe increasing LED_MAX to 0x1f. Otherwise, looks good to me. But please don't forgot to put maintainers on CC. Thanks David > Change-Id: If25d8a8e2570dfab3a35f9be5b1d03ab662f6b1c > Signed-off-by: Michael Wright <[email protected]> > --- > drivers/hid/hid-input.c | 4 ++++ > include/uapi/linux/input.h | 4 ++++ > 2 files changed, 8 insertions(+) > > diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c > index 2619f7f..a1cb3bf 100644 > --- a/drivers/hid/hid-input.c > +++ b/drivers/hid/hid-input.c > @@ -633,6 +633,10 @@ static void hidinput_configure_usage(struct hid_input > *hidinput, struct hid_fiel > case 0x4b: map_led (LED_MISC); break; /* "Generic > Indicator" */ > case 0x19: map_led (LED_MAIL); break; /* "Message > Waiting" */ > case 0x4d: map_led (LED_CHARGING); break; /* "External > Power Connected" */ > + case 0x4f: map_led (LED_PLAYER_1); break; /* "Player 1" > */ > + case 0x50: map_led (LED_PLAYER_2); break; /* "Player 2" > */ > + case 0x51: map_led (LED_PLAYER_3); break; /* "Player 3" > */ > + case 0x52: map_led (LED_PLAYER_4); break; /* "Player 4" > */ > > default: goto ignore; > } > diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h > index 1874ebe..bb43f20 100644 > --- a/include/uapi/linux/input.h > +++ b/include/uapi/linux/input.h > @@ -908,6 +908,10 @@ struct input_keymap_entry { > #define LED_MISC 0x08 > #define LED_MAIL 0x09 > #define LED_CHARGING 0x0a > +#define LED_PLAYER_1 0x0b > +#define LED_PLAYER_2 0x0c > +#define LED_PLAYER_3 0x0d > +#define LED_PLAYER_4 0x0e > #define LED_MAX 0x0f > #define LED_CNT (LED_MAX+1) > > -- > 2.1.0.rc2.206.gedb03e5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
