Hi Jaewon, I think you better to use ':' instead of '-'. - before: Input: misc: max77693-haptic - - after : Input: misc: max77693-haptic:
On 10/15/2014 12:16 PM, Jaewon Kim wrote: > In order to avoid duplicated execution, max77693_haptic_disable() > check disable state. But it was reversed. this patch fix it. > > Signed-off-by: Jaewon Kim <[email protected]> > --- > drivers/input/misc/max77693-haptic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/misc/max77693-haptic.c > b/drivers/input/misc/max77693-haptic.c > index d605db4..7b1fde9 100644 > --- a/drivers/input/misc/max77693-haptic.c > +++ b/drivers/input/misc/max77693-haptic.c > @@ -152,7 +152,7 @@ static void max77693_haptic_disable(struct > max77693_haptic *haptic) > { > int error; > > - if (haptic->enabled) > + if (!haptic->enabled) > return; > > error = max77693_haptic_configure(haptic, false); > If you modify patch name, Looks good to me. Reviewed-by: Chanwoo Choi <[email protected]> Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
