On Tue, Dec 30, 2014 at 11:47:16AM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <[email protected]>
>
> According to Documentation/CodingStyle - Chapter 14:
>
> "The preferred form for passing a size of a struct is the following:
>
> p = kmalloc(sizeof(*p), ...);
>
> The alternative form where struct name is spelled out hurts readability and
> introduces an opportunity for a bug when the pointer variable type is changed
> but the corresponding sizeof that is passed to a memory allocator is not."
>
> So do it as recommeded.
>
> Signed-off-by: Fabio Estevam <[email protected]>
Applied, thank you.
> ---
> drivers/input/keyboard/imx_keypad.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/input/keyboard/imx_keypad.c
> b/drivers/input/keyboard/imx_keypad.c
> index e53f232..2e855e6 100644
> --- a/drivers/input/keyboard/imx_keypad.c
> +++ b/drivers/input/keyboard/imx_keypad.c
> @@ -448,8 +448,7 @@ static int imx_keypad_probe(struct platform_device *pdev)
> return -ENOMEM;
> }
>
> - keypad = devm_kzalloc(&pdev->dev, sizeof(struct imx_keypad),
> - GFP_KERNEL);
> + keypad = devm_kzalloc(&pdev->dev, sizeof(*keypad), GFP_KERNEL);
> if (!keypad) {
> dev_err(&pdev->dev, "not enough memory for driver data\n");
> return -ENOMEM;
> --
> 1.9.1
>
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
