Hi Daniel,
On Tue, Jan 27, 2015 at 3:34 AM, Daniel Martin
<[email protected]> wrote:
> From: Daniel Martin <[email protected]>
>
> If we queried min/max dimensions of x [1266..5674], y [1170..4684] we
> have post-2013 model and don't need to apply any quirk.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=91541
> Signed-off-by: Daniel Martin <[email protected]>
> ---
> drivers/input/mouse/synaptics.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 37d4dff..f6c43ff 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -420,6 +420,11 @@ static int synaptics_quirks(struct psmouse *psmouse)
> struct synaptics_data *priv = psmouse->private;
> int i;
>
> + /* Post-2013 models expose correct dimensions. */
> + if (priv->x_min == 1266 && priv->x_max == 5674 &&
> + priv->y_min == 1170 && priv->y_max == 4684)
> + return 0;
> +
Well, this one, I don't like it either :(
At least, the test should be within the psmouse_matches_pnp_id() below
to ensure we are deciding with Lenovo devices only.
The other concern is hardcoding these values in the code directly.
What if Synaptics/Lenovo decides to ship a new released model with
proper min_max ranges but with a different offset?
Andrew told us that the board ID should be enough to discriminate old
and faulty touchpads from the new and valid touchpads.
My concern here is that we will have to backport these changes in the
various stable kernel and the various distributions. And if we do not
end up with the right solution right now, that means that we will have
to do the job over and over.
I am quite tempted to find a solution in the userspace for that fix.
Not sure I'll be able to find the right one right now, but it may
worth trying.
Cheers,
Benjamin
> for (i = 0; min_max_pnpid_table[i].pnp_ids; i++) {
> if (psmouse_matches_pnp_id(psmouse,
> min_max_pnpid_table[i].pnp_ids)) {
> --
> 2.2.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
