On Sun, Mar 22, 2015 at 10:43 AM, Gabriele Mazzotta <[email protected]> wrote: > The minimum value these sensors can report is 4, so this should be the > value used when W is not reporting the width. > > Signed-off-by: Gabriele Mazzotta <[email protected]> > --- > drivers/input/mouse/synaptics.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c > index 133e488..a7a0e73 100644 > --- a/drivers/input/mouse/synaptics.c > +++ b/drivers/input/mouse/synaptics.c > @@ -1018,7 +1018,7 @@ static void synaptics_process_packet(struct psmouse > *psmouse) > > if (hw.z > 0 && hw.x > 1) { > num_fingers = 1; > - finger_width = 5; > + finger_width = 4;
I am not sure about this change. It looks benign, but I don't get how changing the local variable finger_width can change anything in the CR48 processing. Except for this one (which could be dropped IMO), the *rest* of the series is: Reviewed-by: Benjamin Tissoires <[email protected]> Thanks for pushing this Gabriele. Cheers, Benjamin > if (SYN_CAP_EXTENDED(priv->capabilities)) { > switch (hw.w) { > case 0 ... 1: > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
