On Fri, May 22, 2015 at 10:07:49AM +0200, Alexandre Belloni wrote: > Hi, > > This looks good to me, a few nits below > > On 22/05/2015 at 00:16:47 +0800, [email protected] wrote : > > - spin_unlock_irqrestore(&data->lock, flags); > > + regmap_update_bits(data->regmap, data->offset + SNVS_LPCR, > > + (SNVS_LPCR_LPTA_EN | SNVS_LPCR_LPWUI_EN), > That line is not properly aligned (missing one space) > > [...] > > > + if (of_device_is_compatible(snvs_np, "syscon")) { > > + data->regmap = syscon_node_to_regmap(snvs_np); > > + data->offset = 0x34; > > + } else { > > + pr_warning("snvs rtc: you use old dts file, please update > > it\n"); > > This should be pr_warn()
It should be dev_warn(). Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
