On Mon, May 25, 2015 at 10:30:04PM +0530, Shailendra Verma wrote: > The return type of the function samsung_keypad_report() is bool but we are > returning the unsigned int value.So changing the unsigned int to bool type > and initializing with false. > > Signed-off-by: Shailendra Verma <[email protected]> > --- > drivers/input/keyboard/samsung-keypad.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/samsung-keypad.c > b/drivers/input/keyboard/samsung-keypad.c > index 6b9fdf6..44b1ba9 100644 > --- a/drivers/input/keyboard/samsung-keypad.c > +++ b/drivers/input/keyboard/samsung-keypad.c > @@ -112,7 +112,7 @@ static bool samsung_keypad_report(struct samsung_keypad > *keypad, > struct input_dev *input_dev = keypad->input_dev; > unsigned int changed; > unsigned int pressed; > - unsigned int key_down = 0; > + bool key_down = false;
No, this causes conversion bool->unsigned int->bool on every iteration of the loop. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
