On Thu, Jun 04, 2015 at 09:54:34AM -0400, Benjamin Tissoires wrote: > On Jun 04 2015 or thereabouts, Hans de Goede wrote: > > On some v7 devices (e.g. Lenovo-E550) the deltas reported are typically > > only in the 0-1 range dividing this by 2 results in a range of 0-0. > > > > And even for v7 devices where this does not lead to making the trackstick > > entirely unusable, it makes it twice as slow as before we added v7 support > > and were using the ps/2 mouse emulation of the dual point setup. > > > > If some kind of generic slowdown is actually necessary for some devices, > > then that belongs in userspace, not in the kernel. > > > > Cc: [email protected] > > Reported-and-tested-by: Rico Moorman <[email protected]> > > Signed-off-by: Hans de Goede <[email protected]> > > --- > > Changes in v2: > > -Also remove the comment why we were dividing the delta by 2 > > --- > > Looks good to me > > Reviewed-by: Benjamin Tissoires <[email protected]>
Applied, thank you. > > Cheers, > Benjamin > > > drivers/input/mouse/alps.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c > > index 9bc4343..113d6f1 100644 > > --- a/drivers/input/mouse/alps.c > > +++ b/drivers/input/mouse/alps.c > > @@ -1071,9 +1071,8 @@ static void alps_process_trackstick_packet_v7(struct > > psmouse *psmouse) > > right = (packet[1] & 0x02) >> 1; > > middle = (packet[1] & 0x04) >> 2; > > > > - /* Divide 2 since trackpoint's speed is too fast */ > > - input_report_rel(dev2, REL_X, (char)x / 2); > > - input_report_rel(dev2, REL_Y, -((char)y / 2)); > > + input_report_rel(dev2, REL_X, (char)x); > > + input_report_rel(dev2, REL_Y, -((char)y)); > > > > input_report_key(dev2, BTN_LEFT, left); > > input_report_key(dev2, BTN_RIGHT, right); > > -- > > 2.4.2 > > -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
