On 08/20/2015 06:33 PM, Mark Brown wrote: > On Fri, Aug 07, 2015 at 09:32:13AM -0700, Dmitry Torokhov wrote: >> On Fri, Aug 07, 2015 at 10:13:48AM +0200, Lars-Peter Clausen wrote: > >>> We know that it is used when CONFIG_PM_SLEEP is defined and we know that it >>> is unused CONFIG_PM_SLEEP is not defined. Marking the function as >>> __maybe_unused will cause the compiler to not generate a warning when the >>> function is really unused. Making this explicit works much better. > >> It will also drop the code form the final image and having the functions >> in provides better compile coverage. > > Just discussed this in person with Dmitry: I'll apply the patch just now > for v4.3 and we can incrementally improve the ifdef handling after.
Great, thanks. I was about to send a patch with the ifdefs removed tomorrow.
signature.asc
Description: OpenPGP digital signature
