2015-10-09 22:00 GMT+09:00 Luis de Bethencourt <lui...@osg.samsung.com>: > Since hid_connect() only cares about hiddev_connect() succeeding or > failing, there is no need for this function to return an int and it can > return a bool instead.
It can return bool but it would not be in line with kernel coding style. The hiddev_connect() I believe is an action, so "the function should return an error-code integer.". Best regards, Krzysztof > > Suggested-by: Jiri Kosina <ji...@kernel.org> > Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> > --- > > Hi, > > No idea why my local build did not complain about the obvious mistake > on the previous version of the patch. > > Sorry about that, > Luis > > drivers/hid/hid-core.c | 2 +- > drivers/hid/usbhid/hiddev.c | 10 +++++----- > include/linux/hid.h | 2 +- > include/linux/hiddev.h | 2 +- > 4 files changed, 8 insertions(+), 8 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
