Thomas Hood wrote :
>
> Hi. Here's a patch for drivers/net/irda/nsc-ircc.c
> 80% of the changes are minor changes to messages,
> designed to make them all consistent.
>
> The other 20% fix a number of bugs.
Great work !
> > @@ -160,7 +160,7 @@
> > int i = 0;
> >
> > /* Probe for all the NSC chipsets we know about */
> > - for (chip=chips; chip->name ; chip++,i++) {
> > + for (chip=chips; chip->name ; chip++) {
>
> Variable "i" counts the number of found chips. With
> the "i++" here, if one has a PC97338 then one has to
> enter "irq=4,4 io=0x3e8,0x3e8" as the options.
Correct. Not many people are using those options.
> [...]
> > - if (io[i] < 2000) {
> > + if (io[i] < 0x2000) {
>
> Typo.
Ouch !
> [...]
> >
> > - pnp = (reg >> 4) & 0x01;
> > + pnp = (reg >> 3) & 0x01;
>
> An important change. The pnp flag is bit 3, not bit 4.
> See datasheet.
Re-Ouch !
What's the impact ?
> > --- net/irda/af_irda.c_2.4.2 Mon Jan 29 01:59:34 2001
> > +++ net/irda/af_irda.c Mon Feb 26 19:12:12 2001
> > @@ -2434,5 +2434,7 @@
> >
> > MODULE_AUTHOR("Dag Brattli <[EMAIL PROTECTED]>");
> > MODULE_DESCRIPTION("The Linux IrDA Protocol Subsystem");
> > +#ifdef CONFIG_IRDA_DEBUG
> > MODULE_PARM(irda_debug, "1l");
> > +#endif
> > #endif /* MODULE */
>
> Without this, if CONFIG_IRDA_DEBUG is not defined then irda_debug
> is an unresolved symbol.
Good one...
Dag : any comments ?
Jean
_______________________________________________
Linux-IrDA mailing list - [EMAIL PROTECTED]
http://www.pasta.cs.UiT.No/mailman/listinfo/linux-irda
