Here's a request of the driver writers.
When printing out a hex number, please precede it always with "0x".
I.e., do
printf( "blah blah = 0x%x\n", val );
instead of
printf( "blah blah = %x\n", val );
There are lots of cases right now where hex numbers are printed
out without being tagged as such, which may result in confusion.
E.g.
jdthood@thanatos:/usr/src/linux-2.4.5-ac9/drivers/net/irda$ grep '%x' *
irda-usb.c: IRDA_DEBUG(0, "Vendor: %x, Product: %x\n", dev->descriptor.idVendor,
dev->descriptor.idProduct);
irda-usb.c: WARNING("usb-irda: usb_get_class_descriptor failed (0x%x)\n",
ret);
irda-usb.c: printk("bLength=%x\n", desc->bLength);
[...]
In particular, please change nsc-ircc.c as follows:
jdthood@thanatos:/usr/src/linux-2.4.5-ac9/drivers/net/irda$ diff -Naur nsc-ircc.c_ORIG
nsc-ircc.c
--- nsc-ircc.c_ORIG Mon Jun 11 00:19:26 2001
+++ nsc-ircc.c Mon Jun 11 00:22:11 2001
@@ -701,7 +701,7 @@
/* Should be 0x2? */
if (0x20 != (version & 0xf0)) {
- ERROR("%s, Wrong chip version %02x\n", driver_name, version);
+ ERROR("%s, Wrong chip version 0x%x\n", driver_name, version);
return -1;
}
--
Thomas Hood
_______________________________________________
Linux-IrDA mailing list - [EMAIL PROTECTED]
http://www.pasta.cs.UiT.No/mailman/listinfo/linux-irda
