-----Original Message-----
From: Steven Walter [mailto:[EMAIL PROTECTED]]On Behalf Of
Steven Walter
Sent: 30. desember 2001 22:23
To: [EMAIL PROTECTED]
Subject: [PATCH] irport: check request_region return value


I recently changed several drivers in drivers/net of the Linux kernel to
correctly check the return value of request_region.  Since you appear
to be the maintainer of this driver, I'm forwarding the patch to you.

Thanks
--
-Steven
In a time of universal deceit, telling the truth is a revolutionary act.
                        -- George Orwell
He's alive.  He's alive!  Oh, that fellow at RadioShack said I was mad!
Well, who's mad now?
                        -- Montgomery C. Burns

diff -Nru clean-2.4.17//drivers/net/irda/irport.c
linux/drivers/net/irda/irport.c
--- clean-2.4.17//drivers/net/irda/irport.c     Mon Nov  5 19:23:13 2001
+++ linux/drivers/net/irda/irport.c     Thu Dec 27 14:06:16 2001
@@ -169,13 +169,11 @@
         self->io.fifo_size = 16;

        /* Lock the port that we need */
-       ret = check_region(self->io.sir_base, self->io.sir_ext);
-       if (ret < 0) {
+       if (!request_region(self->io.sir_base, self->io.sir_ext, driver_name)) {
                IRDA_DEBUG(0, __FUNCTION__ "(), can't get iobase of 0x%03x\n",
                           self->io.sir_base);
                return NULL;
        }
-       request_region(self->io.sir_base, self->io.sir_ext, driver_name);

        /* Initialize QoS for this device */
        irda_init_max_qos_capabilies(&self->qos);



_______________________________________________
Linux-IrDA mailing list  -  [EMAIL PROTECTED]
http://www.pasta.cs.UiT.No/mailman/listinfo/linux-irda

Reply via email to