kevin thayer wrote :
>
> I've an HP OmniBook 6100 running linux 2.4.18 and I've
> had a bear of a time getting IR support up and going.

        Classical.

> for example irdadump (at least in my
> case) needed to be told which irda device (irda0) to
> listen on or else it just sat there and showed
> nothing.

        For me, it has always worked with "nothing". Weird.

> It was a PC87388, id 0, cid_mask 248, revision ??

        So, that's a new hardware ? And you got it to work like this
first time ? Congratulation !
        Make sure you check operation at 4Mb/s. Most drivers work well
at 115k (for example, even with wrong dongle_id), but 4Mb/s is where
you need everything right.

> -       { "PC87338", { 0x398, 0x15c, 0x2e }, 0x08,
> 0xb0, 0xf8, 
> +       { "PC87338", { 0x2e, 0x398, 0x15c }, 0x08,
> 0xb0, 0xf8, 
>           nsc_ircc_probe_338, nsc_ircc_init_338 },

        It's a new hardware, so don't hack the previous entry, just
add a new one. As it is, I can't merge your patch in the kernel.
        The additional bonus is that the log will report the correct
chip number (87388 instead of 87338).

> +                       /* if ((id & chip->cid_mask) == chip->cid_value) { */

        You need to put the right value in the struct above.

> +       /* Should be 0x2? 
>         if (0x20 != (version & 0xf0)) {

        Same here, put a proper test. Maybe you need to extend the
above struct (chip->version_mask) so to get something clean in here.

        Jean
_______________________________________________
Linux-IrDA mailing list  -  [EMAIL PROTECTED]
http://www.pasta.cs.UiT.No/mailman/listinfo/linux-irda

Reply via email to