Jean Tourrilhes <[EMAIL PROTECTED]> writes:
> Hi everybody...
>
> I added a new feature to connect : if you don't specify a
> device address, the IrDA stack will try to find one for you (doing
> discovery and all that jazz). Of course, if you specify an address,
> the old behaviour is used...
> Patch below...
>
> Jean
>
> -------------------------------------
> --- af_irda.dag2.c Mon Dec 6 13:32:26 1999
> +++ af_irda.c Mon Dec 6 13:48:08 1999
> @@ -451,6 +451,71 @@ static int irda_find_lsap_sel(struct ird
> }
>
> /*
> + * Function irda_discover_lsap_sel (self, name)
> + *
> + * Try to lookup LSAP selector in all remote LM-IAS that we can connect to
> + *
> + */
> +static int irda_discover_lsap_sel(struct irda_sock *self, char *name)
> +{
> + discovery_t *discovery;
Looks OK, but I don't like the name. This function discovers device
addresses, not lsap selectors. You'll have to query the remote IAS (as the
comment says) to look up the lsap sel, but this is not what this function
is doing. It is just checking the discovery log for the device addresses
stored after receiving XID (eXchange station ID) frames. Should probably be
called irda_discover_devices, or irda_do_discovery instead.
-- Dag
--
/ Dag Brattli | The Linux-IrDA Project /
// University of Tromsoe, Norway | Infrared communication for Linux //
/// http://www.cs.uit.no/~dagb | http://www.cs.uit.no/linux-irda/ ///
_______________________________________________
Linux-IrDA mailing list - [EMAIL PROTECTED]
http://www4.pasta.cs.UiT.No/mailman/listinfo/linux-irda
