John Ioannidis <[EMAIL PROTECTED]> writes: > Among the problems I've found: > > in the utils, irattach.c, the variable "fir" in function main (line > 308 or so) is declared, but not given a value before it is tested in > line 373. Yes, this looks like a real bugger to me! > Lots of ioctl calls don't get their return values checked, so the > program fails without any indication of what went wrong. > > This is a real pisser: > > in irattach.c, we see this line: > > #define IRTTY_IOCGNAME _IOR(IRTTY_IOC_MAGIC, 2, struct irtty_info) > > where irtty_info is 20 bytes long. Yet in the kernel source, in > include/net/irda/irtty.h, the same definition reads: > > #define IRTTY_IOCGET _IOR(IRTTY_IOC_MAGIC, 2, struct irtty_info) Not that dangerous since the data is only copied out of the kernel, and into a larger buffer (20 bytes instead of 6). > No wonder irattach was not starting up. Could you please try out irda-utils-0.9.9.tar.gz and check out if it works OK for you? -- Dag -- / Dag Brattli | The Linux-IrDA Project / // University of Tromsoe, Norway | Infrared communication for Linux // /// http://www.cs.uit.no/~dagb | http://www.cs.uit.no/linux-irda/ /// _______________________________________________ Linux-IrDA mailing list - [EMAIL PROTECTED] http://www4.pasta.cs.UiT.No/mailman/listinfo/linux-irda
