2006-07-29: EV dixit: > 2006-07-29: Keith Bennett dixit: > > [...] > > On a slightly un-related note, I saw that kfs_write() copies > > everything into a malloced buffer before passing it on to > > lk_karma_write_file_chunk(). The comment suggests that this is > > a necessary evil, but I could see nothing in the two > > lk_karma_write_file_chunk() which supported this. Am I missing > > something? > > I don remember the details, but I do remember spending a lot of > time with troubles related with the handling of buffers of both > lk_karma_read_file_chunk() and lk_karma_write_file_chunk(). > I'll revise this part later and I'll let you know.
I've changed: - res = lk_karma_write_file_chunk(karma, offset, size, fid, 0, myBuf); + res = lk_karma_write_file_chunk(karma, offset, size, fid, 0, (char *)buf); The (char *) is required because FUSE buf is "const char *" (may be we should change the lk_karma_write_file_chunk() protorype?). I've made a few tests and it seems to work properly. This change will be included in the upcomming release, along with your new escape-edditing code. Thanks for spotting this one! Best, EV. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-karma-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-karma-devel
