> > - Use EV's empirically determined 5s timeout instead of 6s > > Why? It is only an upper limit and shouldn't matter. I would've thought > it would be better to err on the side of a longer timeout to avoid the > possibility that it might need changing yet again in the future. If you > think that 5s will be enough for all users then I guess that's okay. I'm > not so sure though.
Yeah.. I just haven't run into any instances after bumping it up to 5s that wouldn't work. But I don't really care, so maybe I'll switch it back. > This is the way I use my player all the time now - I just leave it plugged > in via usb and mount/eject as needed. If you think that it will make a > big difference to the patches acceptance then remove it but I would rather > it stayed if possible. Okay but how do you remount the device after doing the eject? As in, what commands do you use? (I honestly don't know.) Kernel memory is a precious resource; it cannot be swapped out or used by anything else in the kernel once allocated, so IMHO even a 512 byte buffer shouldn't stick around more than we need it to. Kmalloc will generally return dead buffers from the size-512 slab cache without having to do an alloc anyway. > This is just to prevent the sequence number from overflowing. Since it > is an unsigned char, the test is a bit redundant and can be removed. Ok, maybe: if (seq == 0) seq = 1; > > If you are fine with the changes, please add a Signed-off-by line as in > > Documentation/SubmittingPatches, then I'll push a version of this upstream > > that applies against my previously submitted timeout patch. > > I'll read through the changes properly this evening. Cool. -- Bob Copeland %% www.bobcopeland.com ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-karma-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-karma-devel
