On Tue, Aug 15, 2006, EV wrote: > > Asides from that, I think that this is not guaranteed to work. > > taglib seems to be a bit dumb when it comes to autodetecting > > file types and when it fails it will set tl_file to NULL. The > > taglib_file_tag() will then segfault. > > If TagLib_File_FLAC is undefined because there is no support > > for FLAC files then this is a pointless test which is > > guaranteed to fail anyway. On the other hand, if older versions > > of taglib do support FLAC files but just don't provide a file > > type flag, then an extra test is needed to check that the > > taglib_file_new() has succeeded. > > In older tag_c libs, TagLib_File_FLAC is undefined. Many users
Because there is no support for FLAC? > (me ;) dont use FLAK tunes. Fairly enough, they want to use > libkarma even with not-so-new computers or systems. It's no good > if a user upgrades from libkarma-0.0.5 to 0.0.5-hg98 just to see > that it no longer compiles or works in the computer it used to > work flawlesly. I have no problem with defining the constant in order to allow compilation, but you should then recognise that it is an unsupported file format and take appropriate action. > So, we need that a) libkarma compiles even with not-so-new libs > and b) libkarma run as correctly as possible with the existing > lib support. I'll revise my changes as soon as Franky's > repository is in sync with all the patches so far. Like I said before, I think that the easiest way is for you to re-send your patch based on the current status of the repository. If you would rather I applied the tags patch first, let me know and I will re-send. Keith. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-karma-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-karma-devel
