Hi Vegard.
On Fri, Oct 26, 2007 at 08:46:14PM +0200, Vegard Nossum wrote:
> Hi,
>
> I observe that arch/x86/pci/Makefile_32 specifies obj-y += $(pci-y).
> Shouldn't this strictly be obj-y += pci.o?
pci-y := fixup.o
pci-$(CONFIG_ACPI) += acpi.o
pci-y += legacy.o irq.o
pci-$(CONFIG_X86_VISWS) := visws.o fixup.o
pci-$(CONFIG_X86_NUMAQ) := numa.o irq.o
obj-y += $(pci-y) common.o early.o
The above is the full snippet from said Makefile.
Notice the CONFIG_X86_VISWS and CONFIG_X86_NUMAQ cannot be yes
at the same time. his is because thay are choice options
where only one can be selected.
If neither is 'y' then the three assingments:
pci-y := fixup.o
pci-$(CONFIG_ACPI) += acpi.o
pci-y += legacy.o irq.o
take effect.
But consider when CONFIG_VISWS is 'y' then the assignmnet
pci-$(CONFIG_X86_VISWS) := visws.o fixup.o
becomes:
pci-y := visws.o fixup.o
so it overwrites the former default pci-y value (notice the ':=').
This is a typical way to implement a chained if in kbuild.
So the above Makefile snippet is correct.
Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
