On Sat, 17 Nov 2007, Sam Ravnborg wrote: > > - # drivers/sound/emu10k1/Makefile > > - ccflags-y += -I$(obj) > > - ccflags-$(DEBUG) += -DEMU10K1_DEBUG > > + #arch/x86/boot/Makefile > > + $(obj)/bzImage: ccflags-y := -D__BIG_KERNEL__ > > It is more important to show the use of ccflags-$(CONFIG_xxx) than > to be an exact copy from the file. In this case the correct fix is > to update drivers/sound/emu10k1/Makefile to use ccflags-y
the only reason i used the arch/x86/boot/Makefile example above is that it is literally the only place that "ccflags-y" is used in a makefile in the entire tree: $ grep -rw ccflags-y * arch/x86/boot/Makefile:$(obj)/bzImage: ccflags-y := -D__BIG_KERNEL__ Documentation/kbuild/makefiles.txt: ccflags-y, asflags-y and ldflags-y Documentation/kbuild/makefiles.txt: ccflags-y specifies options for compiling C files with $(CC). Documentation/kbuild/makefiles.txt: ccflags-y += -I$(obj) Documentation/kbuild/makefiles.txt: ccflags-y := $(call cc-ifversion, -lt, 0402, -O1) Documentation/kbuild/makefiles.txt: In this example, ccflags-y will be assigned the value -O1 if the scripts/Makefile.build:ccflags-y := scripts/Makefile.lib:ccflags-y += $(EXTRA_CFLAGS) scripts/Makefile.lib:_c_flags = $(KBUILD_CFLAGS) $(ccflags-y) $(CFLAGS_$(basetarget).o) $ and the use of "ldflags-y" and "asflags-y" is equally rare. so, just to make sure i understand what *should* be happening, are you saying that the current uses of EXTRA_CFLAGS should be replaced by ccflags-y, and so on and so on? because if that's the recommended transformation, it certainly doesn't look like much has happened with it. or am i misunderstanding what's supposed to be happening here? rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://crashcourse.ca ======================================================================== - To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
