On Sun, Feb 10, 2008 at 11:59:40PM +0100, Sam Ravnborg wrote:
> make V=1 is broken at the moment.
>
> I do not have possibility to look at it until
> in ~20 hours.
> So if anyone can help until then...
>
> To reproduce:
>
> make defconfig
> make V=1
>
Somehow $(quiet) == "", when it should be "silent_". Thus command is
empty (just ";"), which is error.
,--`make V=1`--
| GEN /dev/shm/blinux/Makefile
|set -e; ; mkdir -p include/linux/;
[]
|/bin/sh: Syntax error: ";" unexpected
`--
That "silent" juggling with `echo` is overhead, thus remove it.
Signed-off-by: Oleg Verych <[EMAIL PROTECTED]>
--
My (i.e. wrong:) view of the patch. Side effect -- empty line in V=2
garbage output.
--- /mnt/work/pc/kernel.org/git-repoes/linux-2.6/scripts/Kbuild.include
2008-02-11 02:05:18.619239750 +0100
+++ /mnt/zdev0/linux-2.6/scripts/Kbuild.include 2008-02-11 03:30:11.000000000
+0100
@@ -39,19 +39,18 @@
# - If they are equal no change, and no timestamp update
# - stdin is piped in from the first prerequisite ($<) so one has
# to specify a valid file as first prerequisite (often the kbuild file)
- quiet_chk_filechk = echo ' CHK $@'
-silent_chk_filechk = :
- quiet_upd_filechk = echo ' UPD $@'
-silent_upd_filechk = :
+quiet_chk_filechk = ' CHK $@'
+quiet_upd_filechk = ' UPD $@'
+
define filechk
$(Q)set -e; \
- $($(quiet)chk_filechk); \
+ echo $($(quiet)chk_filechk); \
mkdir -p $(dir $@); \
$(filechk_$(1)) < $< > [EMAIL PROTECTED]; \
if [ -r $@ ] && cmp -s $@ [EMAIL PROTECTED]; then \
rm -f [EMAIL PROTECTED]; \
else \
- $($(quiet)upd_filechk); \
+ echo $($(quiet)upd_filechk); \
mv -f [EMAIL PROTECTED] $@; \
fi
endef
-
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
