On Wed, Aug 15, 2007 at 01:04:05PM +0400, Alexey Dobriyan wrote:
> On 8/15/07, Fengguang Wu <[EMAIL PROTECTED]> wrote:
> > proc_mounts.m.buf is not explicitly zeroed at allocation time, which
> > may later confuse the seqfile code and triggle an kfree(m->buf).
>
> It's cleared in seq_open().
So it is :)
> > --- linux.orig/fs/proc/base.c
> > +++ linux/fs/proc/base.c
> > @@ -380,7 +380,7 @@ static int mounts_open(struct inode *ino
> >
> > if (ns) {
> > ret = -ENOMEM;
> > - p = kmalloc(sizeof(struct proc_mounts), GFP_KERNEL);
> > + p = kzalloc(sizeof(struct proc_mounts), GFP_KERNEL);
> > if (p) {
> > file->private_data = &p->m;
> > ret = seq_open(file, &mounts_op);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
