On 2025-08-20 08:55, Mathieu Desnoyers wrote:
Michael, can you try it out ?
Will do.
Kienan, we may want to add a configuration forcing "-fno-common" to our CI, this problematic pattern may be hiding other issues elsewhere. I'm thinking of LTTng-UST tracepoint headers and libside headers.
AFAIK, -fno-common has been the default since GCC 10 so it's already well tested in CI, there are a few fixes from around 2020 in LTTng related to this.
Sean, do you want to contribute the fix to librseq as well ?
Librseq currently doesn't have the weak symbols like the selftests so the fix doesn't really apply.
Thanks everyone for looking into this. I'll be back from vacation next week and will resume normal operations. :-) Mathieu*/ -__weak ptrdiff_t __rseq_offset; -__weak unsigned int __rseq_size; -__weak unsigned int __rseq_flags; +extern __weak ptrdiff_t __rseq_offset; +extern __weak unsigned int __rseq_size; +extern __weak unsigned int __rseq_flags;static const ptrdiff_t *libc_rseq_offset_p = &__rseq_offset;static const unsigned int *libc_rseq_size_p = &__rseq_size; @@ -209,7 +209,7 @@ void rseq_init(void) * libc not having registered a restartable sequence. Try to find the * symbols if that's the case. */ - if (!*libc_rseq_size_p) { + if (!libc_rseq_size_p || !*libc_rseq_size_p) { libc_rseq_offset_p = dlsym(RTLD_NEXT, "__rseq_offset"); libc_rseq_size_p = dlsym(RTLD_NEXT, "__rseq_size"); libc_rseq_flags_p = dlsym(RTLD_NEXT, "__rseq_flags"); base-commit: c17b750b3ad9f45f2b6f7e6f7f4679844244f0b9
