> -----Original Message-----
> From: Peng Fan (OSS) <peng....@oss.nxp.com>
> Sent: Thursday, August 21, 2025 6:03 AM
> To: Shenwei Wang <shenwei.w...@nxp.com>
> Cc: Bjorn Andersson <anders...@kernel.org>; Mathieu Poirier
> <mathieu.poir...@linaro.org>; Rob Herring <r...@kernel.org>; Krzysztof
> Kozlowski <krzk...@kernel.org>; Conor Dooley <conor...@kernel.org>; Shawn
> Guo <shawn...@kernel.org>; Sascha Hauer <s.ha...@pengutronix.de>; Linus
> Walleij <linus.wall...@linaro.org>; Bartosz Golaszewski <b...@bgdev.pl>;
> Pengutronix Kernel Team <ker...@pengutronix.de>; Fabio Estevam
> <feste...@gmail.com>; Peng Fan <peng....@nxp.com>; linux-
> remotep...@vger.kernel.org; devicet...@vger.kernel.org; i...@lists.linux.dev;
> linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org;
> dl-linux-imx
> <linux-...@nxp.com>
> Subject: Re: [PATCH 2/4] remoteproc: imx_rproc: Populate devices under
> "rpmsg" subnode
> >
> > #include "imx_rproc.h"
> >@@ -1084,6 +1088,126 @@ static int imx_rproc_sys_off_handler(struct
> sys_off_data *data)
> > return NOTIFY_DONE;
> > }
> >
>
> Just wonder could the changes be moved to drivers/rpmsg?
Since the DTS node is under imx_rproc, the most straightforward approach is to
implement the
feature here. Moving the implementation to drivers/rpmsg would introduce
additional complexity
and might be less direct.
Thanks,
Shenwei
>
> >+struct imx_rpmsg_driver {
> >+ struct rpmsg_driver rpdrv;
> >+ void *driver_data;
> >+};
> >+
> >+ i = drvdata->map_idx;
> >+ if (i >= ARRAY_SIZE(channel_device_map))
> >+ return -ENODEV;
> >+
> >+ auxdata = devm_kzalloc(dev, sizeof(*auxdata)*2, GFP_KERNEL);
> >+ if (!auxdata)
> >+ return -ENOMEM;
> >+
> >+ u8 major;
> >+ u8 minor;
> >+ u8 type;
> >+ u8 cmd;
> >+ u8 reserved[5];
> >+} __packed;
>
> A comment should be added to describe each member.
>
> Regards,
> Peng
