NIT:
Sagi Shahar wrote:
> Move kernel segment definitons to a separate file which can be included
^^^^^^^^^^
definitions
And in the subject.
Otherwise seems reasonable.
Reviewed-by: Ira Weiny <ira.we...@intel.com>
> from assembly files.
>
> Signed-off-by: Sagi Shahar <sa...@google.com>
> ---
> .../selftests/kvm/include/x86/processor_asm.h | 12 ++++++++++++
> tools/testing/selftests/kvm/lib/x86/processor.c | 5 +----
> 2 files changed, 13 insertions(+), 4 deletions(-)
> create mode 100644 tools/testing/selftests/kvm/include/x86/processor_asm.h
>
> diff --git a/tools/testing/selftests/kvm/include/x86/processor_asm.h
> b/tools/testing/selftests/kvm/include/x86/processor_asm.h
> new file mode 100644
> index 000000000000..7e5386a85ca8
> --- /dev/null
> +++ b/tools/testing/selftests/kvm/include/x86/processor_asm.h
> @@ -0,0 +1,12 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Used for storing defines used by both processor.c and assembly code.
> + */
> +#ifndef SELFTEST_KVM_PROCESSOR_ASM_H
> +#define SELFTEST_KVM_PROCESSOR_ASM_H
> +
> +#define KERNEL_CS 0x8
> +#define KERNEL_DS 0x10
> +#define KERNEL_TSS 0x18
> +
> +#endif // SELFTEST_KVM_PROCESSOR_ASM_H
> diff --git a/tools/testing/selftests/kvm/lib/x86/processor.c
> b/tools/testing/selftests/kvm/lib/x86/processor.c
> index 6dbf40cbbc2a..4802fc81bea7 100644
> --- a/tools/testing/selftests/kvm/lib/x86/processor.c
> +++ b/tools/testing/selftests/kvm/lib/x86/processor.c
> @@ -7,6 +7,7 @@
> #include "test_util.h"
> #include "kvm_util.h"
> #include "processor.h"
> +#include "processor_asm.h"
> #include "sev.h"
> #include "tdx/tdx_util.h"
>
> @@ -14,10 +15,6 @@
> #define NUM_INTERRUPTS 256
> #endif
>
> -#define KERNEL_CS 0x8
> -#define KERNEL_DS 0x10
> -#define KERNEL_TSS 0x18
> -
> vm_vaddr_t exception_handlers;
> bool host_cpu_is_amd;
> bool host_cpu_is_intel;
> --
> 2.51.0.rc1.193.gad69d77794-goog
>
