On Thu, Jan 29, 2026 at 09:24:54PM +0000, David Matlack wrote:
> diff --git a/drivers/vfio/pci/vfio_pci_liveupdate.c
> b/drivers/vfio/pci/vfio_pci_liveupdate.c
> @@ -192,10 +200,24 @@ static struct liveupdate_file_handler
> vfio_pci_liveupdate_fh = {
>
> int __init vfio_pci_liveupdate_init(void)
> {
> + int ret;
> +
> if (!liveupdate_enabled())
> return 0;
>
> - return liveupdate_register_file_handler(&vfio_pci_liveupdate_fh);
> + ret = liveupdate_register_file_handler(&vfio_pci_liveupdate_fh);
> + if (ret)
> + return ret;
> +
> + ret = pci_liveupdate_register_fh(&vfio_pci_liveupdate_fh);
May be we should rename pci_liveupdate_register_fh() to something like
pci_register_to_liveupdate_flb(). In the current way, it is confusing to
why same handler is getting registered at two places.
Above name will also make it similar to IOMMU series as well
https://lore.kernel.org/kvm/[email protected]/
