> From the next time, please don't post a new version of a patch as a reply to > the previous version. Post a new version as a new thread, with changelogs [1] > including links to previous revisions. > > Also, give others sufficient time, say, one day, to add comments before > posting > a new version. If someone publicly asked questions to your patch, please > answer the questions and keep the discussion in public until the discussion is > clearly completed, before posting a new version.
Got it! Will keep it in mind for next time. Sorry about all the confusion! :) > > The obsolete_target test spawns three sh processes and uses their pids > > as DAMON monitoring targets. These processes are never terminated or > > waited on, so they are left running (or become zombies) as orphaned > > children after the test program exits. > > > > Terminate each process and communicate() with it after the targets are > > no longer needed, so it exits and gets reaped instead of being leaked. > > Makes sense to me. Thank you for this patch. Ofc, happy to contribute! > > > > Signed-off-by: Hari Mishal <[email protected]> > > Reviewed-by: SJ Park <[email protected]> > > > --- > > v2: Terminate each sh process directly instead of giving it its own > > stdin pipe to close, dropping the stdin=PIPE changes and shrinking > > the diff. > > When you add changelog, please add links to the previous revisions. > > Finally, please use mm-new [2] as the baseline of DAMON patches from the next > time. > > This patch is applied to damon/next [2] tree. If this patch is not added to > mm.git in short term (~1 week?), I will ask mm.git maintainer (Andrew Morton) > to pick this. So, no action from your side is needed for now. If it seems I > also forgot doing that or you cannot wait for my action, please feel free to > directly ask that to Andrew. > I'm quite happy to wait! Thanks for your clarity. > We (mm community) now want to focus on making mm.git more stabilized and > therefore ready for the next merge window, rather than adding more changes > that > are not really urgent. I agree and want to help [1] that. For the reason, > unless Andre pick this first, I will request adding this to mm.git only after > next -rc1 release. Let me know if you think this is really urgent. > > [1] https://lore.kernel.org/[email protected] Definitely don't think it's an urgent change. Anyone who is using a tool like damon would be able to debug this quite easily. Thanks for clarity, again. Accidentally dropped reply all AGAIN, sorry about this. Resending to make sure everything is public again. Cheers, Hari
