Title: [3906] trunk/drivers/spi/spi_bfin5xx.c: [#3697] remove useless return status check in restore_state function pointed by Michael .
Revision
3906
Author
cooloney
Date
2007-11-20 22:44:52 -0600 (Tue, 20 Nov 2007)

Log Message

[#3697] remove useless return status check in restore_state function pointed by Michael.

Diffstat

 spi_bfin5xx.c |   15 ++-------------
 1 files changed, 2 insertions(+), 13 deletions(-)

Modified Paths

Diff

Modified: trunk/drivers/spi/spi_bfin5xx.c (3905 => 3906)


--- trunk/drivers/spi/spi_bfin5xx.c	2007-11-21 02:51:05 UTC (rev 3905)
+++ trunk/drivers/spi/spi_bfin5xx.c	2007-11-21 04:44:52 UTC (rev 3906)
@@ -223,10 +223,9 @@
 #define MAX_SPI_SSEL	7
 
 /* stop controller and re-config current chip*/
-static int restore_state(struct driver_data *drv_data)
+static void restore_state(struct driver_data *drv_data)
 {
 	struct chip_data *chip = drv_data->cur_chip;
-	int ret = 0;
 
 	/* Clear status and disable clock */
 	write_STAT(drv_data, BIT_STAT_CLR);
@@ -239,13 +238,6 @@
 
 	bfin_spi_enable(drv_data);
 	cs_active(drv_data, chip);
-
-	if (ret)
-		dev_dbg(&drv_data->pdev->dev,
-			": request chip select number %d failed\n",
-			chip->chip_select_num);
-
-	return ret;
 }
 
 /* used to kick off transfer in rx mode */
@@ -971,10 +963,7 @@
 
 	/* Setup the SSP using the per chip configuration */
 	drv_data->cur_chip = spi_get_ctldata(drv_data->cur_msg->spi);
-	if (restore_state(drv_data)) {
-		spin_unlock_irqrestore(&drv_data->lock, flags);
-		return;
-	};
+	restore_state(drv_data);
 
 	list_del_init(&drv_data->cur_msg->queue);
 
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
http://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits

Reply via email to