On Nov 25, 2007 5:08 PM,  <[EMAIL PROTECTED]> wrote:
> --- trunk/drivers/serial/8250.c 2007-11-25 22:05:33 UTC (rev 3932)
> +++ trunk/drivers/serial/8250.c 2007-11-25 22:08:02 UTC (rev 3933)
> @@ -92,7 +92,9 @@
>  */
>  #define CONFIG_HUB6 1
>
> +#ifndef CONFIG_BLACKFIN
>  #include <asm/serial.h>
> +#endif
>
>  /*
>  * SERIAL_PORT_DFNS tells us about built-in ports that have no
> @@ -1544,6 +1546,10 @@
>  i->head = &up->list;
>  spin_unlock_irq(&i->lock);
>
> +#ifdef CONFIG_BLACKFIN
> + irq_flags |= IRQF_TRIGGER_HIGH;
> +#endif
> +
>  ret = request_irq(up->port.irq, serial8250_interrupt,
>  irq_flags, "serial", i);
>  if (ret < 0)

how about creating asm-blackfin/serial.h and putting a line:
#define SERIAL_EXTRA_IRQ_FLAGS IRQF_TRIGGER_HIGH

and then in the source code you can trivially do:
#ifdef SERIAL_EXTRA_IRQ_FLAGS
irq_flags |= SERIAL_EXTRA_IRQ_FLAGS;
#endif

and then there is no ugly Blackfin-specific defines in the file
-mike
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
http://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits

Reply via email to