And can we add a proc interface to show all the GPIO list requested by drivers. It is very useful for debugging and system information
-Thanks >-----Original Message----- >From: [EMAIL PROTECTED] >[mailto:[EMAIL PROTECTED] On >Behalf Of Wu, Bryan >Sent: Thursday, December 06, 2007 5:20 PM >To: Mike Frysinger; [EMAIL PROTECTED] >Cc: [email protected] >Subject: RE: >[Linux-kernel-commits][3995]trunk/sound/soc/blackfin/bf5xx-ac97 >.c: bug[#3725]forBF54X, GPIO 19 label should be NULL > >We have to remove all the NULL in the gpio_request and >peripheral_request. > >1. A driver gpio_request GPIO 1 with NULL 2. B driver >gpio_request GPIO 1 with NULL, it passes no dump_stack(). >But this operation should fail. >2. if B driver gpio_request GPIO 1 with LABEL_B, it fails. But >this operation in B driver is right. > >so solutions: >1. gpio_request and peripheral_request should check (label != >NULL) 2. remove all the NULL label in the gpio_request and >peripheral_request. > >--- >[EMAIL PROTECTED]:/opt/svn/bf54x/linux-2.6.x$ grep -rn "gpio_request" >drivers/ | grep NULL | grep -v svn >drivers/media/video/blackfin/mt9m001.c:1683: if >(gpio_request(uCAM_LEDS, NULL)) { >drivers/media/video/blackfin/mt9m001.c:1688: if >(gpio_request(uCAM_TRIGGER, NULL)) { >drivers/media/video/blackfin/mt9m001.c:1695: if >(gpio_request(uCAM_STANDBY, NULL)) { >drivers/media/video/blackfin/mt9m001.c:1748: if >(gpio_request(uCAM_FS3, NULL)) { >drivers/mtd/nand/bfin_nand.c:212: if >(gpio_request(CONFIG_BFIN_NAND_READY, NULL)) >drivers/mtd/maps/bf5xx-flash.c:96: >if(gpio_request(CONFIG_ENET_FLASH_PIN, NULL)){ >drivers/input/misc/bf53x_pfbuttons.c:360: if >(gpio_request(gpios[i], NULL)) { >drivers/video/bf54x-lq043.c:243: if (gpio_request(disp, NULL)) { >drivers/pcmcia/bfin_cf_pcmcia.c:218: if(gpio_request(cd_pfx, NULL)){ >drivers/char/tea5764.c:431: if(gpio_request(TIME_MEASURE_GPIO, >NULL)){ >drivers/char/bfin_pflags.c:131: if(gpio_request(minor, NULL)){ >drivers/usb/gadget/net2272.c:2510: if(gpio_request(GPIO_0, NULL)){ >drivers/usb/gadget/net2272.c:2514: if(gpio_request(GPIO_1, NULL)){ >drivers/usb/gadget/net2272.c:2526: if(gpio_request(GPIO_11, NULL)) >{ >drivers/usb/gadget/net2272.c:2541: >if(gpio_request(GPIO_6, NULL)) { >drivers/usb/gadget/net2272.c:2555: >if(gpio_request(GPIO_47, NULL)){ >drivers/zaptel/bfsi.c:386: >gpio_request(reset_port[reset_bit],NULL); >drivers/zaptel/bfsi-spi-framework.c:543: >gpio_request(reset_port[reset_bit],NULL); >--- > >Thanks >-Bryan > >>-----Original Message----- >>From: [EMAIL PROTECTED] >>[mailto:[EMAIL PROTECTED] On >Behalf Of >>Mike Frysinger >>Sent: Thursday, December 06, 2007 4:28 PM >>To: [EMAIL PROTECTED] >>Cc: [email protected] >>Subject: Re: [Linux-kernel-commits] >>[3995]trunk/sound/soc/blackfin/bf5xx-ac97.c: bug[#3725]for BF54X,GPIO >>19 label should be NULL >> >>On Dec 6, 2007 1:17 AM, <[EMAIL PROTECTED]> wrote: >>> Revision 3995 Author cliff Date 2007-12-06 00:17:29 -0600 (Thu, 06 >>> Dec >>> 2007) >>> Log Message bug[#3725]for BF54X, GPIO 19 label should be NULL >>> >>> Modified: trunk/sound/soc/blackfin/bf5xx-ac97.c (3994 => 3995) >>> +#if defined(CONFIG_BF54x) >>> + if (gpio_request(CONFIG_SND_BF5XX_RESET_GPIO_NUM, NULL)) { #else >>> if (gpio_request(CONFIG_SND_BF5XX_RESET_GPIO_NUM, "SND_AD198x >>> RESET")) { >> >>why ? it doesnt make sense unless you're trying to hack hook in >>behavior which should be fixed properly in another way ... >>-mike >>_______________________________________________ >>Linux-kernel-commits mailing list >>[email protected] >>http://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits >> > >_______________________________________________ >Linux-kernel-commits mailing list >[email protected] >http://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits > _______________________________________________ Linux-kernel-commits mailing list [email protected] http://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
