On Dec 17, 2007 1:30 PM, Robin Getz <[EMAIL PROTECTED]> wrote:
> On Mon 17 Dec 2007 09:14, [EMAIL PROTECTED] pondered:
> > static int cmp_label(unsigned short ident, const char *label)
> > {
> > - if (label == NULL)
> > + if (label == NULL) {
> > + printk(KERN_ERR"Please provide none-null label\n");
> > dump_stack();
> > + }
>
> before this change, you got:
>
> 0 Target : <0x0000470c> { _dump_stack + 0x0 }
> Source : <0x00005dd0> { _cmp_label + 0x58 }
> 1 Target : <0x00005dd0> { _cmp_label + 0x58 }
> Source : <0x00005d84> { _cmp_label + 0xc }
> 2 Target : <0x00005d78> { _cmp_label + 0x0 }
> Source : <0x00005fd4> { _gpio_request + 0x14 }
> 3 Target : <0x00005fc0> { _gpio_request + 0x0 }
> Source : <0x00184128> { _bfin_nand_init + 0x54 }
> 4 Target : <0x00184118> { _bfin_nand_init + 0x44 }
>
> Now with this change - you will see a dump of printk.
>
> Any objections with :
> dump_stack();
> printk(KERN_ERR"Please provide none-null label\n");
in general, i think having the error message after large chunks of
output is better than before as people more often read starting from
the bottom ... also, make sure you put a space after KERN_ERR ;)
-mike
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
http://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
