On Mon, 2007-12-10 at 21:08 +0800, [EMAIL PROTECTED] wrote:
> Revision
>         4012
> Author
>         hennerich
> Date
>         2007-12-10 07:08:04 -0600 (Mon, 10 Dec 2007)
> Log Message
> [#3477] Replace current blackfin specific pfbutton driver with kernel
> generic gpio key driver
> 
> - local patch only -

Michael, 

Is there any other method that does not hack the common code?
or send out some request to LKML for some feedback.

You know, the driver in mainline is changing. Try to keep a local patch
is not a good idea.

Thanks
-Bryan Wu



> Diffstat
> gpio_keys.c |   15 ++++++++++++++-
>  1 files changed, 14 insertions(+), 1 deletion(-)
> Modified Paths
>       * trunk/drivers/input/keyboard/gpio_keys.c
> Diff
> Modified: trunk/drivers/input/keyboard/gpio_keys.c (4011 => 4012)
> 
> --- trunk/drivers/input/keyboard/gpio_keys.c  2007-12-10 11:36:33 UTC (rev 
> 4011)
> +++ trunk/drivers/input/keyboard/gpio_keys.c  2007-12-10 13:08:04 UTC (rev 
> 4012)
> @@ -27,6 +27,18 @@
>  
>  #include <asm/gpio.h>
>  
> +#if defined(CONFIG_BLACKFIN) && !defined(BF548_FAMILY)
> +
> +/*
> + * On some Blackfin CPUs reading edge triggered
> + * GPIOs doesn't return the current value
> + */
> +
> +#define GPIOKEYS_EDGE_SENSE(x) set_gpio_edge(gpio, x)
> +#else
> +#define GPIOKEYS_EDGE_SENSE(x) do {} while (0)
> +#endif
> +
>  static irqreturn_t gpio_keys_isr(int irq, void *dev_id)
>  {
>       int i;
> @@ -40,8 +52,9 @@
>  
>               if (irq == gpio_to_irq(gpio)) {
>                       unsigned int type = button->type ?: EV_KEY;
> +                     GPIOKEYS_EDGE_SENSE(0);
>                       int state = (gpio_get_value(gpio) ? 1 : 0) ^ 
> button->active_low;
> -
> +                     GPIOKEYS_EDGE_SENSE(1);
>                       input_event(input, type, button->code, !!state);
>                       input_sync(input);
>               }
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
http://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits

Reply via email to