Thanks for comments. I was thinking the 80-column is a strict rule to make kernel patch acceptable. I will revise these changes. -Yi
On Fri, 2008-01-25 at 11:25 -0500, Mike Frysinger wrote: > On Wednesday 23 January 2008 03:01:10 [EMAIL PROTECTED] wrote: > > more fix to bug [#3846]. > > - use _rambase as the start of kernel image. kernel is in the region > > [_rambase, _ramstart] - count in pages in per-cpu-page list as available > > memory > > - reserved memory now include: [0 - 4K] for bad pointer catching, memory > > reserved for abnormaly 05000263, memory reserved by kernel itself. > > > > Modified: trunk/arch/blackfin/kernel/setup.c (4141 => 4142) > > > > - printk(KERN_INFO "Kernel managed physical pages: %lu\n", > > num_physpages); > > + printk(KERN_INFO "Kernel managed physical pages: %lu\n", > > + num_physpages); > > ... > > - reservedpages += (_ramend - memory_end - DMA_UNCACHED_REGION) >> > > PAGE_SHIFT; > > + reservedpages += (_ramend - memory_end - DMA_UNCACHED_REGION) >> > > + PAGE_SHIFT; > > ... > > - "Memory available: %luk/%luk RAM, (%uk init code, %uk kernel > > code, %uk data, %uk dma, %uk reserved)\n", > > + "Memory available: %luk/%luk RAM, " > > + "(%uk init code, %uk kernel code, " > > + "%uk data, %uk dma, %uk reserved)\n", > > changing wrapping because it improves readability is fine, but strictly > adhering to the 80 col rule just makes things harder to read. in these cases, > forcing the wrapping is unnecessary and makes things worse. > -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] http://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
