On Tue, 2008-01-29 at 14:57 +0800, adam - Li Yi wrote:
> If this code make it hard to be acceptable for mainline, I will change
> to other ways (it is basically copied from i386 BTW).
>
Thanks for the understanding.
Tons of old code (e.g. i386) can not pass the checkpatch.pl.
So we should be the good example for other developer.
If it is very difficult, you can provide meaningful reasons and mainline
will accept it as an exception.
Regards,
-Bryan.
> -Yi
>
> On Tue, 2008-01-29 at 14:42 +0800, adam - Li Yi wrote:
> > Similar.
> >
> > printk(KERN_DEBUG "abc");
> > printk("def\n");
> >
> > is NOT the same as
> >
> > printk(KERN_DEBUG, "abc");
> > printk(KERN_DEBUG, "def\n");
> >
> > that is "KERN_" is "line" based.
> > -Yi
> >
> >
> > On Tue, 2008-01-29 at 13:33 +0800, Bryan Wu wrote:
> > > On Tue, 2008-01-29 at 13:02 +0800, adam - Li Yi wrote:
> > > > e.g, I expect the format looks like:" boot memmap: 0000000000177000 -
> > > > 0000000000400000 (usable)",
> > > >
> > > > if "printk(KERN_DEBUG "(reserved)\n")", I got message:
> > > >
> > >
> > > How about KERN_INFO?
> > >
> > > -Bryan
> > >
> > > > "boot memmap: 0000000000177000 - 0000000000400000 <7> (usable)"
> > > >
> > > > -Yi
> > > >
> > > > On Tue, 2008-01-29 at 12:56 +0800, adam - Li Yi wrote:
> > > > > It give warning like this:
> > > > >
> > > > > "printk() should include KERN_ facility level
> > > > > #230: FILE: setup.c:333:
> > > > > + printk("(reserved)\n");
> > > > > "
> > > > >
> > > > > But I have to not to use any KERN_ in order to get expected message
> > > > > format.
> > > > >
> > > > > -Yi
> > > > >
> > > > > On Mon, 2008-01-28 at 10:04 -0500, Robin Getz wrote:
> > > > > > On Mon 28 Jan 2008 00:11, [EMAIL PROTECTED] pondered:
> > > > > >
> > > > > > > [!no_src_qa!]'
> > > > > > >
> > > > > > >
> > > > > > > * trunk/arch/blackfin/kernel/setup.c
> > > > > > > * trunk/arch/blackfin/mm/init.c
> > > > > >
> > > > > > What was needed to this [!no_src_qa!] ?
> > > > > >
> > > > > > If we are only changing things in arch/blackfin, we should not need
> > > > > > to do this
> > > > > > (I would think? - Otherwise it just forces Bryan to fix things
> > > > > > before he
> > > > > > sends to Linus anyway).
> > > > > >
> > > > > > -Robin
> > > > > >
> > > > > > -Robin
> > > > _______________________________________________
> > > > Linux-kernel-commits mailing list
> > > > [email protected]
> > > > http://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
http://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
