Title: [5254] trunk/arch/blackfin/kernel/kgdb.c: Task[#3428] Ignore hardware data watchpoint.
- Revision
- 5254
- Author
- sonicz
- Date
- 2008-09-08 03:16:38 -0500 (Mon, 08 Sep 2008)
Log Message
Task[#3428] Ignore hardware data watchpoint.
Because hardware data watchpoint implemented in current blackfin design
can not trigger an exception event as what hardware instruction
watchpoint does, gdb command to set hardware data watchpoint is ignored.
This can be turned on easily after future blackfin include this support.
Modified Paths
Diff
Modified: trunk/arch/blackfin/kernel/kgdb.c (5253 => 5254)
--- trunk/arch/blackfin/kernel/kgdb.c 2008-09-08 07:50:53 UTC (rev 5253)
+++ trunk/arch/blackfin/kernel/kgdb.c 2008-09-08 08:16:38 UTC (rev 5254)
@@ -209,7 +209,13 @@
return -ENOSPC;
}
- for (breakno = 0; breakno < HW_WATCHPOINT_NUM; breakno++)
+ /* Becasue hardware data watchpoint impelemented in current
+ * Blackfin can not trigger an exception event as the hardware
+ * instrction watchpoint does, we ignaore all data watch point here.
+ * They can be turned on easily after future blackfin design
+ * supports this feature.
+ */
+ for (breakno = 0; breakno < HW_INST_WATCHPOINT_NUM; breakno++)
if (bfin_type == breakinfo[breakno].type
&& !breakinfo[breakno].occupied) {
breakinfo[breakno].occupied = 1;
@@ -339,10 +345,10 @@
if (enable_wp) {
bfin_write_WPIACTL(WPPWR);
CSYNC();
+ bfin_write_WPIACTL(wpiactl|WPPWR);
+ bfin_write_WPDACTL(wpdactl);
+ CSYNC();
}
- bfin_write_WPIACTL(wpiactl|WPPWR);
- bfin_write_WPDACTL(wpdactl);
- CSYNC();
}
void kgdb_disable_hw_debug(struct pt_regs *regs)
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
http://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
