On Tue 30 Sep 2008 15:57, Mike Frysinger pondered: > On Tue, Sep 30, 2008 at 15:40, <[EMAIL PROTECTED]> wrote: > > Modified: trunk/include/asm-blackfin/mach-bf527/bf527.h (5362 => 5363) > > #ifdef CONFIG_BF527 > > #define CPU "BF527" > > +#define CPUID 0x27e4 > > #endif > > #ifdef CONFIG_BF525 > > #define CPU "BF525" > > +#define CPUID 0x27e4 > > #endif > > #ifdef CONFIG_BF522 > > #define CPU "BF522" > > +#define CPUID 0x27e4 > > #endif > > #ifndef CPU > > #define CPU "UNKNOWN" > > i think we should change all of these "#ifndef CPU" logic to errors. > after all, we have no handling for BF523/BF524/BF526 atm.
Yeah, that makes sense to me. It should not build unless properly configured... I will update everything to #error "building for unknown CPU type - please fix configuration" Unless you can thing of something else that is more clear? > > Modified: trunk/include/asm-blackfin/mach-bf548/bf548.h (5362 => 5363) > > #if defined(CONFIG_BF542) > > # define CPU "BF542" > > -# define CPUID 0x027c8000 > > +# define CPUID 0x27c8 > > #elif defined(CONFIG_BF544) > > # define CPU "BF544" > > -# define CPUID 0x027c8000 > > +# define CPUID 0x27c8 > > #elif defined(CONFIG_BF547) > > # define CPU "BF547" > > #elif defined(CONFIG_BF548) > > # define CPU "BF548" > > -# define CPUID 0x027c6000 > > +# define CPUID 0x27c6 > > #elif defined(CONFIG_BF549) > > # define CPU "BF549" > > +# define CPUID 0x27c8 > > #else > > # define CPU "UNKNOWN" > > # define CPUID 0x0 > > our rurjtag has BF548 listed as 0010011111011110 ... I expect that a few of the other numbers are wrong too - for now, it just prints out a warning - (but I did try building a kernel for 537, and booting it on a 526, and with earlyprintk - I saw the expected error message...) If anyone notices other issues - let me know - I'll test on the various platforms I have access to... -Robin _______________________________________________ Linux-kernel-commits mailing list [email protected] http://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
