On Fri, Dec 26, 2008 at 04:49,  <[email protected]> wrote:
> +#if defined(CONFIG_BF54x)
>       host->irq = IRQ_SDH_MASK0;
> +     host->dma_ch = CH_SDH;
> +#elif defined(CONFIG_BF51x)
> +     host->irq = IRQ_RSI_INT0;
> +     host->dma_ch = CH_RSI;
> +#endif

i thought these should be moved to platform resources

> +#if defined(CONFIG_BF54x)
> +     /* Secure Digital Host has control of DMAC1 channel 10 resources */
> +     bfin_write_DMAC1_PERIMUX(bfin_read_DMAC1_PERIMUX() | 0x1);
>       /* Enable peripheral function of SD pins */
>       bfin_write_PORTC_FER(bfin_read_PORTC_FER() | 0x3F00);
>       bfin_write_PORTC_MUX(bfin_read_PORTC_MUX() & ~0xFFF0000);
> -     SSYNC();
> +#elif defined(CONFIG_BF51x)
> +     bfin_write_PORTG_FER(bfin_read_PORTG_FER() | 0x01F8);
> +     bfin_write_PORTG_MUX((bfin_read_PORTG_MUX() & ~0x3FC) | 0x154);
> +#endif

we have a portmux framework you should be using.  no driver should be
touching any mux/fer registers anymore.
-mike
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
http://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits

Reply via email to