On Sun, Jan 4, 2009 at 10:03, Robin Getz wrote: > On Sun 4 Jan 2009 03:25, [email protected] pondered: >> --- trunk/drivers/mmc/host/bfin_sdh.c 2009-01-01 22:36:34 UTC (rev 5939) >> +++ trunk/drivers/mmc/host/bfin_sdh.c 2009-01-04 08:25:55 UTC (rev 5940) > And when comparing some of the functions to others in drivers/mmc/host/* - > they have more functions marked __init or __devinit than we do - any reason? > > ricoh_mmc.c:static int __devinit ricoh_mmc_probe(struct pci_dev *pdev, > ricoh_mmc.c: .probe = ricoh_mmc_probe, > > static int __init mmc_omap_probe(struct platform_device *pdev) > .probe = mmc_omap_probe, > > static int __devinit au1xmmc_probe(struct platform_device *pdev) > .probe = au1xmmc_probe, > > no __init in our driver... > static int sdh_probe(struct platform_device *pdev) > .probe = sdh_probe,
people use __init instead of __devinit either because they dont know any better or they dont want to support hotplugging. we should be using __devinit in ours. -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] http://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
