On Mon, Jan 5, 2009 at 00:07, Robin Getz wrote: > On Sun 4 Jan 2009 23:14, Mike Frysinger pondered: >> On Sun, Jan 4, 2009 at 23:10, Cai, Cliff wrote: >> >From: Mike Frysinger [mailto:[email protected]] >> >>On Sun, Jan 4, 2009 at 21:26, <[email protected]> wrote: >> >>> -static int sdh_remove(struct platform_device *pdev) >> >>> +static int __devexit sdh_remove(struct platform_device *pdev) >> >> >> >>you'll need to update the platform_driver definition then to use >> >>__devexit_p() around the remove function >> >>-mike >> > >> > I guess I get confused about this,there are all kinds of such >> > annotatins in the drivers under host. >> > >> > I really don't know which one is the most suitable,any document? >> >> the ones with "dev" in it are for hotpluging. so probe/remove >> functions.of driver structures which can be dynamically run when >> hotpluging is enabled. the ones without "dev" in it means it can only >> be executed once (so all the code/data that is used to bring up the >> system during boot, or the functions that are only run when a module >> is loaded). > > So - in the mmc/sd case: > - things that touch the controller only (which can not be hot plugged) - > should be without dev. > - things that touch the card (which can be hot plugged, if enabled) should > have the "dev".
what Cliff committed is correct imo -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] http://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
