Because KGDB L2 test case for blackfin asks the test code to be built into module while, common KGDB_TESTCASE can't be built into module.
Sonic -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Mike Frysinger Sent: Wednesday, January 07, 2009 12:49 PM To: Bryan Wu Cc: [email protected]; [email protected] Subject: Re: [Linux-kernel-commits] [5916] trunk: [#2443] Add in the kgdbtest config. On Tue, Jan 6, 2009 at 22:37, Bryan Wu wrote: > On Mon, Dec 29, 2008 at 8:06 PM, Mike Frysinger wrote: >> On Sun, Dec 28, 2008 at 22:53, <[email protected]> wrote: >>> Revision 5916 Author grace Date 2008-12-28 21:53:04 -0600 (Sun, 28 >>> Dec 2008) >>> >>> Log Message >>> >>> [#2443] Add in the kgdb test config. >>> >>> --- trunk/arch/blackfin/kernel/Makefile 2008-12-28 22:43:23 UTC (rev 5915) >>> +++ trunk/arch/blackfin/kernel/Makefile 2008-12-29 03:53:04 UTC (rev 5916) >>> @@ -21,6 +21,6 @@ >>> obj-$(CONFIG_CPLB_INFO) += cplbinfo.o >>> obj-$(CONFIG_MODULES) += module.o >>> obj-$(CONFIG_KGDB) += kgdb.o >>> -obj-$(CONFIG_KGDB_TESTS) += kgdb_test.o >>> +obj-$(CONFIG_KGDB_TESTCASE) += kgdb_test.o >> >> if CONFIG_KGDB_TESTS isnt used anymore, then you need to remove it >> from the Kconfig: >> >>> +config KGDB_TESTCASE >>> + tristate "KGDB: for test case in expect" >>> + default n >>> + help >>> + This is a kgdb test case for automated testing. >>> + >>> config KGDB_TESTS >>> bool "KGDB: internal test suite" >>> default n >> > > I suggest to move this Kconfig things to our > arch/blackfin/Kconfig.debug, not touch the common code. > I'll do it later. or we just change our testsuites to use the common value ... i dont see any reason why KGDB_TESTCASE is required instead of KGDB_TESTS -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] http://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits _______________________________________________ Linux-kernel-commits mailing list [email protected] http://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
