On Mon, Jan 12, 2009 at 14:32, Robin Getz wrote: > On Mon 12 Jan 2009 13:58, Mike Frysinger pondered: >> On Mon, Jan 12, 2009 at 13:39, <[email protected]> wrote: >> > --- trunk/arch/blackfin/include/asm/pda.h 2009-01-12 18:37:22 UTC (rev >> > 5998) >> > +++ trunk/arch/blackfin/include/asm/pda.h 2009-01-12 18:39:25 UTC (rev >> > 5999) >> > @@ -59,6 +59,7 @@ >> > unsigned long icplb_fault_addr; >> > unsigned long retx; >> > unsigned long seqstat; >> > + unsigned int __nmi_count; /* number of NMI on this CPUs */ >> > }; >> >> dont think this needs __ prefix ... it's already in the cpu_pda >> struct, so there really isnt namespace pollution to avoid >> >> also, the comment indicates that this is like the number of available >> NMIs on the proc rather than the NMI *event* count > > I just used what was in arch/x86/include/asm/pda.h > > unsigned int __nmi_count; /* number of NMI on this CPUs */ > > Doesn't mean it is correct (I'll change it if you poke me again) - but that > is where I grabbed it from.
i guess __ can stay, but really the comment should be cleaned up (both in terms of clarity and grammar) -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] http://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
