On Tue, Jan 13, 2009 at 00:35, <[email protected]> wrote: > +void bfin_gpio_reset_spi0(unsigned int ssel) > { > + u16 gpio; > > + switch (ssel) { > + case 1: > + gpio = P_IDENT(P_SPI0_SSEL1); > + break; > + case 2: > + gpio = P_IDENT(P_SPI0_SSEL2); > + break; > ... > - bfin_gpio_reset_spi0_ssel1(); > + bfin_gpio_reset_spi0(2);
wouldnt it make more sense to pass in P_SPI0_SSEL2 ? the resulting code would be a lot cleaner and i think smaller. -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] http://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
