On Tue, Mar 17, 2009 at 08:57,  <[email protected]> wrote:
> --- trunk/drivers/input/keyboard/Kconfig
> +++ trunk/drivers/input/keyboard/Kconfig
> @@ -341,4 +341,12 @@
> +config KEYBOARD_ADP5520
> +     tristate "Keypad Support for ADP5520 PMIC"
> +     depends on PMIC_ADP5520
> +     help
> +       This option enables support for the keypad scan matrix
> +       on Analog Devices ADP5520 PMICs.
> +

add module name info ?

> --- trunk/drivers/input/keyboard/adp5520-keys.c
> +++ trunk/drivers/input/keyboard/adp5520-keys.c
> @@ -0,0 +1,216 @@
> +static int __devinit adp5520_keys_probe(struct platform_device *pdev)
> +....
> +     dev = kzalloc(sizeof(struct adp5520_keys), GFP_KERNEL);

sizeof(*dev)

> +     input = input_allocate_device();
> +     if (!input) {
> +             kfree(dev);
> +             return -ENOMEM;
> +     }

ret = -ENOMEM;
goto err;

> +     ret = input_register_device(input);
> +     if (ret) {
> +             dev_err(&pdev->dev,
> +                     ": Unable to register input device (%d)\n", ret);
> +             input_free_device(input);
> +             goto err;

why not use err1 ?
-mike
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
http://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits

Reply via email to