On Wed, 2009-05-20 at 06:08 -0400, Mike Frysinger wrote: > On Wed, May 20, 2009 at 05:50, gyang wrote: > > On Wed, 2009-05-20 at 05:36 -0400, Mike Frysinger wrote: > >> On Thu, Jan 22, 2009 at 04:04, <[email protected]> wrote: > >>> Modified: trunk/drivers/net/bfin_mac.c (6031 => 6032) > >>> > >>> /* search for connect PHY device */ > >>> - for (i = 0; i < PHY_MAX_ADDR; i++) { > >>> + for (i = PHY_MAX_ADDR - 1; i >= 0; i--) { > >> > >> why did you change it from searching 0...31 to 31...0 ? the vast > >> majority of boards out there will be sitting at address 0, not 31. > >> this incurs unnecessary overhead and looks like a hack rather than a > >> real fix. > > > > I want to use the PHY at address 2, rather than 0 for KSZ8893M. > > > > I may need to add a Kconfig options to assign the PHY port when enable > > DSA, and then revert this change. > > board resource you mean ... > > maybe we're looking at this the wrong way. there are three devices > listening on MII bus with KSZ8893M. shouldnt they all show up ? if i > look at how wireless is architected, there is a "wmaster#" and a > "wlan#" -- the wmaster# isnt accessed directly, but the wlan# is. or > maybe this isnt relevant at all. The switch chip may have many PHYs, only one have ethernet data connections with blackfin's MAC. And all the PHYs share the MII bus and have address 0, 1, 2, ... > > do we have any examples of how other people are using DSAs ? I will check it.
> -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
