On Mon, May 25, 2009 at 22:32, Robin Getz wrote: > On Mon 25 May 2009 22:18, Mike Frysinger pondered: >> On Mon, May 25, 2009 at 05:16, <[email protected]> wrote: >> > -#if defined(CONFIG_MUSB_DMA_POLL) >> > +/* Sometimes,the DMA complete interrupt never happens, >> > + * this will cause the polling to dead loop. >> > + */ >> > +#if 0 >> > u8 epnum = hw_ep->epnum; >> > u16 dma_reg = 0; >> >> uhh, this is already an ifdef for a reason -- so it can be turned off. >> why does it have to be replaced with an '#if 0' ? > > Yeah - from the description, I would expect this to be associated with an > anomaly number ... > > So, I would think that it would be: > > #if defined(CONFIG_MUSB_DMA_POLL) || ! defined (ANOMALY_xxxxxxx) ?
ANOMALY_xxxx will always be defined .... if that's the case, then it should be right after the system includes: #if ANOMALY_xxxxxxx && defined(CONFIG_MUSB_DMA_POLL) # error ..... #endif or if we dont want to tell people to change their config: #if ANOMALY_xxxxxxx # undef CONFIG_MUSB_DMA_POLL #endif -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
