Title: [6546] trunk/drivers/serial/bfin_sport_uart.c: bug[#2424]drop the patch of flipping buffer in timer function,since the overrun problem doesn't exist even if without this patch in current kenerl
- Revision
- 6546
- Author
- cliff
- Date
- 2009-06-03 03:57:14 -0500 (Wed, 03 Jun 2009)
Log Message
bug[#2424]drop the patch of flipping buffer in timer function,since the overrun problem doesn't exist even if without this patch in current kenerl
Modified Paths
Diff
Modified: trunk/drivers/serial/bfin_sport_uart.c (6545 => 6546)
--- trunk/drivers/serial/bfin_sport_uart.c 2009-06-03 08:44:31 UTC (rev 6545)
+++ trunk/drivers/serial/bfin_sport_uart.c 2009-06-03 08:57:14 UTC (rev 6546)
@@ -88,8 +88,6 @@
struct sport_uart_port {
struct uart_port port;
char *name;
- struct timer_list rx_timer;
- int once;
int tx_irq;
int rx_irq;
int err_irq;
@@ -177,14 +175,6 @@
return 0;
}
-static void rx_push(unsigned long data)
-{
- struct sport_uart_port *up = (struct sport_uart_port *)data;
- struct tty_struct *tty = up->port.info->port.tty;
- tty_flip_buffer_push(tty);
- add_timer(&up->rx_timer);
-}
-
static irqreturn_t sport_uart_rx_irq(int irq, void *dev_id)
{
struct sport_uart_port *up = dev_id;
@@ -200,10 +190,8 @@
else
tty_insert_flip_char(tty, ch, TTY_NORMAL);
} while (SPORT_GET_STAT(up) & RXNE);
- if (up-> 0) {
- add_timer(&up->rx_timer);
- up->
- }
+ tty_flip_buffer_push(tty);
+
return IRQ_HANDLED;
}
@@ -269,10 +257,7 @@
printk(KERN_ERR "Unable to request interrupt %s\n", buffer);
goto fail2;
}
- init_timer(&up->rx_timer);
- up->rx_timer.data = "" long)up;
- up->rx_timer.expires = jiffies + 5;
- up->rx_timer.function = (void *)rx_push;
+
if (port->line) {
if (peripheral_request_list(bfin_uart_pin_req_sport1, DRV_NAME))
goto fail3;
@@ -399,8 +384,6 @@
{
struct sport_uart_port *up = (struct sport_uart_port *)port;
- del_timer(&up->rx_timer);
- up->
pr_debug("%s enter\n", __func__);
/* Disable sport to stop rx */
SPORT_PUT_RCR1(up, (SPORT_GET_RCR1(up) & ~RSPEN));
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
