>-----Original Message----- >From: Mike Frysinger [mailto:[email protected]] >Sent: Tuesday, June 16, 2009 4:48 PM >To: [email protected] >Cc: [email protected] >Subject: Re: [Linux-kernel-commits] [6748] >trunk/drivers/usb/musb/blackfin.h: bug[#5257] include register >definitons if anomaly 05000467 is claimed > >On Tue, Jun 16, 2009 at 04:43, <[email protected]> wrote: >> Log Message >> >> bug[#5257]include register definitons if anomaly 05000467 is claimed >> >> Modified: trunk/drivers/usb/musb/blackfin.h (6747 => 6748) >> >> -#if defined(CONFIG_MUSB_DMA_POLL) >> +#if defined(CONFIG_MUSB_DMA_POLL) || ANOMALY_05000467 >> >> #define USB_DMA_BASE USB_DMA_INTERRUPT >> #define USB_DMAx_CTRL 0x04 > >why make the defines conditional at all ? it isnt like they >make any difference to the resulting compiled code.
I think I should include these register definitions unconditionally. The musb driver include the PIO functions even if it's selected as DMA mode. Cliff _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
