On Thu, Aug 13, 2009 at 00:35, Li Yi wrote: > On Thu, 2009-08-13 at 00:10 -0400, Mike Frysinger wrote: >> On Wed, Aug 12, 2009 at 19:05, <[email protected]> wrote: >> > Modified: trunk/arch/blackfin/include/asm/linkage.h (7167 => 7168) >> > >> > +#define notrace __attribute__((no_instrument_function)) >> >> umm, why ? compiler.h already provides the notrace attribute. > > I am not aware of "compiler.h" has "notrace". (I find it in > arch/x86/include/asm/linkage.h, so copy it). I will remove this. Thanks.
yeah, let's not copy other people's mistakes. compiler.h should be pulled in for everything automatically. > Also we may need to add "notrace" to other functions, like > dump_stack()... i imagine there's many places missing "notrace" markings. -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
