On Tue, Sep 22, 2009 at 23:16, gyang wrote: > On Tue, 2009-09-22 at 09:55 -0400, Mike Frysinger wrote: >> On Tue, Sep 22, 2009 at 04:33, <[email protected]> wrote: >> > Revision 7402 Author gyang Date 2009-09-22 04:33:08 -0400 (Tue, 22 Sep >> > 2009) >> > >> > Log Message >> > >> > Bug [#5546], bfin_write_VR_CTL has been moved to asm/cdef_misc.h >> >> asm/blackfin.h needs to include it then. that header implies all MMRs > > right! > > BTW, > > Hi, Michael, > Can we just use assembly cli/sti to replace the local_irq_save_hw() or > local_irq_restore_hw() in this file? > > Hi, Yi, > Are there affections to the IPIPE function?
no, we should never invoke cli/sti directly when we can avoid it. the common irqflags code needs to hook these points. ipipe takes advantage of that. -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
